refactor: p2p structure, styles and components #8696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… P2PS-269/refactor-styles
… P2PS-269/refactor-styles
… P2PS-269/refactor-styles
… P2PS-269/refactor-styles
… P2PS-354/restructure-p2p-package
…nurzi-deriv/deriv-app into p2p-restructure-and-styles-refactoring
…/farhan-nurzi-deriv/deriv-app into p2p-restructure-and-styles-refactoring
… p2p-restructure-and-styles-refactoring
…les-refactoring FarhanNurzi/P2P Restructure and styles refactoring
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
farrah-deriv
requested review from
prince-deriv and
sandeep-deriv
as code owners
farrah-deriv
removed request for
prince-deriv,
sandeep-deriv and
amina-deriv
ali-hosseini-deriv
previously approved these changes
Sep 18, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This is the feature branch for restructuring the p2p package and refactoring the reusable components. Migrating to TypeScript and unit tests are added.
Each commit is associated with PR which has been already reviewed and merged.
Screenshots:
Please provide some screenshots of the change.